Pass along unknown licenses unclassified #185
Conversation
|
@allenh1 Ptal |
andre-rosa
changed the title
|
This looks good to me. @allenh1 Does Gentoo require that they be specifically classified or from a certain list? If so we could always add an optional argument to this that would trigger the exception if the license can't be classified. And this could be used by Gentoo packaging, but not set by the OpenEmbedded invocation. |
Gentoo doesn't, but a lot of users do. In the past, we had this sort of rule in place (though we just copied the license string in that case). I think that, for now, having an "unclassified" license will be just fine. I think we do a release after this & the rest of the preliminary open embedded PR's come in, then I'll get the automatic license pulling on the docker for the next superflore release. |
- Fixes ros-infrastructure#184 generating qt_metapackages recipes in Melodic - Currently Proprietary and United States Government Purpose licenses aren't matched in SuperFlore and it aborts generation of some melodic packages like qt_metapackages/libqt_core https://github.com/swri-robotics/qt_metapackages/blob/master/libqt_core/package.xml - With the patch, license is output as: ... LICENSE = "United States Government Purpose & SwRI Proprietary" LIC_FILES_CHKSUM = "file://package.xml;beginline=11;endline=11;md5=8e473b26ead33548c945bdaca143a08d" ...
|
@andre-rosa lgtm. Thanks for iterating on this. |
|
Thank you, @allenh1 ! |
- Fixes ros-infrastructure#184 generating qt_metapackages recipes in Melodic
aren't matched in SuperFlore and it aborts generation of some melodic
packages like qt_metapackages/libqt_core
https://github.com/swri-robotics/qt_metapackages/blob/master/libqt_core/package.xml
...
LICENSE = "United States Government Purpose & SwRI Proprietary"
LIC_FILES_CHKSUM = "file://package.xml;beginline=11;endline=11;md5=8e473b26ead33548c945bdaca143a08d"
...