-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --upstream-branch
option
#180
Add --upstream-branch
option
#180
Conversation
7958385
to
a7f4c3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking pretty good. Left a note inline, but it is mostly a nit-pick.
Before this is merged, though, I'd really like to see some test cases introduced for the added option. If we want to, though, we can just create an issue for it after we merge this PR (since I'm not quite sure how in-depth those tests should go).
a7f4c3b
to
459eaa3
Compare
Coverage report for this branch:
Still looking pretty good overall! @tfoote I don't think this affects it much, so I'm going to go ahead and approve this one. I'll leave it to you to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some optional suggestions. lgtm
f5f1333
to
c20d72b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Add `--upstream-branch` option * Add parser tests for missing options * Update README.md with newer command line options
No description provided.