Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python3_6 for ROS 1 #157

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Conversation

concavegit
Copy link
Contributor

@concavegit concavegit commented Jul 5, 2018

This addresses ros/ros-overlay#642

@allenh1
Copy link
Collaborator

allenh1 commented Jul 5, 2018

@concavegit I seem to have made a mistake in assisting you! There's a couple more places to add it.

The example ebuild used for tests:

PYTHON_COMPAT=( python{2_7,3_5} )

Test for the python version:

self.assertTrue('PYTHON_COMPAT=( python{2_7,3_5} )' in got_text)

After those two changes are done, this looks good to me.

@concavegit
Copy link
Contributor Author

All right, added. Thanks for the guidance, it gave me a better idea of the project structure.

@allenh1 allenh1 self-assigned this Jul 5, 2018
Copy link
Collaborator

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- thank you very much!

@allenh1 allenh1 merged commit a3bb8cc into ros-infrastructure:master Jul 5, 2018
zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants