Add --dry-run and --pr-only to Open Embedded #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenh1
changed the title
|
@tfoote I think this one is ready now. The only really questionable part of this PR is the centralization of the parser logic. The only reason for this is to reduce the code duplication among generators, and make it so that the arguments don't have to be listed every time. As this was just an experiment, we can, if this is not your favorite idea, I made it so I can revert it pretty easily if you object. Just let me know. |
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Centralize the save PR logic. * Move parsing logic to a central location to reduce duplication. * Add delta for --only with ebuild generator. * Implement the --dry-run and --pr-only functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress!
So far, only the save and load logic has been centralized. Opening for visibility.
connects to #130.