Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change use of # in generated commit messages to ==... or --... on the next line #228

Closed
herb-kuta-lge opened this issue Sep 3, 2019 · 2 comments
Closed

Change use of # in generated commit messages to ==... or --... on the next line #228

herb-kuta-lge opened this issue Sep 3, 2019 · 2 comments
Assignees
@herb-kuta-lge
Labels
bug enhancement ready

Comments

@herb-kuta-lge
Copy link
Contributor

herb-kuta-lge commented Sep 3, 2019 •
edited
Loading

superflore currently generates commit messages that contain lines starting with the markdown header indicator #. However, commit message lines that start with # are considered comments when amending a commit and are removed unless the user remembers to quote them. Prevent these lines from accidentally being dropped by using the alternate form of header indication: a line starting with =-s or --s underneath the header text.
@herb-kuta-lge herb-kuta-lge self-assigned this Sep 3, 2019
@herb-kuta-lge herb-kuta-lge changed the title Change use of # in generated commit messages to ==... on the next line Change use of # in generated commit messages to ==... or --... on the next line Sep 3, 2019
@allenh1
Copy link
Collaborator

allenh1 commented Sep 3, 2019

However, commit message lines that start with # are considered comments when amending a commit and are removed unless the user remembers to quote them.

Hm... Yeah, that's definitely not so good. Thanks for catching this!

herb-kuta-lge added a commit to herb-kuta-lge/superflore that referenced this issue Sep 4, 2019
@herb-kuta-lge
DRAFT utils.py: Use "="/"-" instead of "#"/"##" for header indication (…
c5f22e6 
…ros-infrastructure#228)
herb-kuta-lge added a commit to herb-kuta-lge/superflore that referenced this issue Nov 15, 2019
@herb-kuta-lge
Prevent accidental removal of headers when amending a commit (ros-inf…
bfe62ba 
…rastructure#228)

superflore currently generates commit messages that contain lines
starting with the markdown header indicator "#". However, commit message
lines that start with "#" are considered comments when amending a commit
and are removed unless the user remembers to quote them. Prevent these
lines from accidentally being removed by using the alternate form of
header indication: a line starting with "="-s or "-"-s underneath the
header text.
herb-kuta-lge added a commit to herb-kuta-lge/superflore that referenced this issue Nov 15, 2019
@herb-kuta-lge
Prevent accidental removal of headers when amending a commit (ros-inf…
7ad8669 
…rastructure#228)

superflore currently generates commit messages that contain lines
starting with the markdown header indicator "#". However, commit message
lines that start with "#" are considered comments when amending a commit
and are removed unless the user remembers to quote them. Prevent these
lines from accidentally being removed by using the alternate form of
header indication: a line starting with "="-s or "-"-s underneath the
header text.
herb-kuta-lge added a commit to herb-kuta-lge/superflore that referenced this issue Nov 15, 2019
@herb-kuta-lge
Prevent accidental removal of headers when amending a commit (ros-inf…
4ff4bf8 
…rastructure#228)

superflore currently generates commit messages that contain lines
starting with the markdown header indicator "#". However, commit message
lines that start with "#" are considered comments when amending a commit
and are removed unless the user remembers to quote them. Prevent these
lines from accidentally being removed by using the alternate form of
header indication: a line starting with "="-s or "-"-s underneath the
header text.
herb-kuta-lge added a commit to herb-kuta-lge/superflore that referenced this issue Nov 15, 2019
@herb-kuta-lge
Prevent accidental removal of headers when amending a commit (ros-inf…
53fc43c 
…rastructure#228)

superflore currently generates commit messages that contain lines
starting with the markdown header indicator "#". However, commit message
lines that start with "#" are considered comments when amending a commit
and are removed unless the user remembers to quote them. Prevent these
lines from accidentally being removed by using the alternate form of
header indication: a line starting with "="-s or "-"-s underneath the
header text.
allenh1 pushed a commit that referenced this issue Nov 15, 2019
@herb-kuta-lge @allenh1
Prevent accidental removal of headers when amending a commit (#228) (#…
f293f3a 
…236)

superflore currently generates commit messages that contain lines
starting with the markdown header indicator "#". However, commit message
lines that start with "#" are considered comments when amending a commit
and are removed unless the user remembers to quote them. Prevent these
lines from accidentally being removed by using the alternate form of
header indication: a line starting with "="-s or "-"-s underneath the
header text.
@herb-kuta-lge
Copy link
Contributor Author

Resolved by #236.

zffgithub pushed a commit to zffgithub/superflore that referenced this issue Apr 11, 2023
@herb-kuta-lge @allenh1
Prevent accidental removal of headers when amending a commit (ros-inf…
95f19b2 
…rastructure#228) (ros-infrastructure#236)

superflore currently generates commit messages that contain lines
starting with the markdown header indicator "#". However, commit message
lines that start with "#" are considered comments when amending a commit
and are removed unless the user remembers to quote them. Prevent these
lines from accidentally being removed by using the alternate form of
header indication: a line starting with "="-s or "-"-s underneath the
header text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herb-kuta-lge herb-kuta-lge

Labels
bug enhancement ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allenh1 @herb-kuta-lge