Print an error level message if package does not start with a letter #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some adversarial testing, we found that we could attempt to create a ROS 2 C++ package that starts with a letter and ament would print a warning level message (I believe using catkin's package naming checks). There would be subsequent compilation errors of course, but it would be good to flag this as an Error earlier if possible.
Is there a reason the error log level check allows for starting with a number?
If we agree on this change I will update existing unit tests as needed.