Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print an error level message if package does not start with a letter #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbbrooks
Copy link

@nbbrooks nbbrooks commented Aug 30, 2024

While doing some adversarial testing, we found that we could attempt to create a ROS 2 C++ package that starts with a letter and ament would print a warning level message (I believe using catkin's package naming checks). There would be subsequent compilation errors of course, but it would be good to flag this as an Error earlier if possible.

WARNING: Package name "1test" does not follow the naming conventions. It should start with a lower case letter and only contain lower case letters, digits, underscores, and dashes.

Is there a reason the error log level check allows for starting with a number?

If we agree on this change I will update existing unit tests as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant