Add trusted_node_data = true to puppet config during reconfigure.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-rivero
reviewed
May 15, 2019
| @@ -23,6 +23,16 @@ elif [[ $# -eq 0 ]] && [[ ! -f "${script_dir}/role" ]]; then | |||
| usage | |||
| fi | |||
|
|
|||
| # Confirm that node-specific facts are usable. | |||
| if ! grep -q '^trusted_node_data ?= ?true' /etc/puppet/puppet.conf; then | |||
There was a problem hiding this comment.
I think that the check for optional space before and after the = is not working (if you run twice the whole bash code you end up with the command inserted twice). This should work the grep pattern:
Suggested change
| if ! grep -q '^trusted_node_data ?= ?true' /etc/puppet/puppet.conf; then | |
| if ! grep -q ''^trusted_node_data[[:space:]]*=[[:space:]]*true'' /etc/puppet/puppet.conf; then | |
| `` |
There was a problem hiding this comment.
Is there some power to doubled single-quotes that I'm not aware of? Or is that part of the suggestion a typo?
There was a problem hiding this comment.
I think this also may just need the Extended Regular Expression engine.
Suggested change
| if ! grep -q '^trusted_node_data ?= ?true' /etc/puppet/puppet.conf; then | |
| if ! grep -Eq '^trusted_node_data ?= ?true' /etc/puppet/puppet.conf; then |
Would you give that a try @j-rivero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros-infrastructure/buildfarm_deployment#211 adds some puppet that uses facts from local node data. This configuration directive is required to do so.