Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum CMake version to allow builds on Focal Fossa (Noetic) #67

Open
gavanderhoorn opened this issue Jan 25, 2020 · 1 comment
Assignees
Labels
help needed wrid21 World ROS-Industrial Day 2021

Comments

@gavanderhoorn
Copy link
Member

See ros/catkin#1052.

@ipa-nhg
Copy link
Member

ipa-nhg commented Sep 29, 2021

I created a bash script to automate this, it is quite simple:

#/bin/bash
mkdir /tmp/ros-i
cd /tmp/ros-i
git clone [email protected]:ros-industrial/motoman
git clone [email protected]:ros-industrial/kuka_experimental
git clone [email protected]:ros-industrial/industrial_calibration
git clone [email protected]:ros-industrial/ros_qtc_plugin
git clone [email protected]:ros-industrial/error_classification_server
git clone [email protected]:ros-industrial/error_resolution_diagnoser
git clone [email protected]:ros-industrial/ros_canopen
git clone [email protected]:ros-industrial/abb_librws
git clone [email protected]:ros-industrial/abb_driver
git clone [email protected]:ros-industrial/industrial_core
git clone [email protected]:ros-industrial/fanuc
git clone [email protected]:ros-industrial/fanuc_experimental
git clone [email protected]:ros-industrial/motoman_experimental
git clone [email protected]:ros-industrial/robotiq
git clone [email protected]:ros-industrial/industrial_pcl
git clone [email protected]:ros-industrial/abb_robot_driver
git clone [email protected]:ros-industrial/abb_robot_driver_interfaces
git clone [email protected]:ros-industrial/abb
git clone [email protected]:ros-industrial/industrial_moveit
git clone [email protected]:ros-industrial/universal_robot -b melodic-devel-staging
git clone [email protected]:ros-industrial/ur_msgs
git clone [email protected]:ros-industrial/staubli
git clone [email protected]:ros-industrial/staubli_val3_driver
git clone [email protected]:ros-industrial/staubli_experimental
git clone [email protected]:ros-industrial/abb_experimental

grep -rl 'cmake_minimum_required(VERSION 2.8.3)' . | xargs sed -i 's/cmake_minimum_required(VERSION 2.8.3)/cmake_minimum_required(VERSION 3.0.2)/g'

cd /tmp/ros-i
for DIR in `ls`;
do
    if [ -d $DIR/.git ];
    then
            echo "...Checking changes for $DIR"
            cd $DIR
            git checkout -b CMakeVersionFocal
            git commit -am 'Increase minimum CMake version to allow builds on Focal Fossa (Noetic)'
            git push [email protected]:ipa-nhg/$DIR CMakeVersionFocal
            cd ..
    fi
done

I will open the derived PRs but probably it will not make sense for many of the repos, likely because they contain an old distro version. For those repos without a CI system for focal I will set the PR as draft and ask the maintainer to decided if the PR should be closed or can be set as "ready" and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help needed wrid21 World ROS-Industrial Day 2021
Development

No branches or pull requests

2 participants