Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPX1950 Support Package #521

Open
wants to merge 2 commits into
base: kinetic-devel
Choose a base branch
from
Open

MPX1950 Support Package #521

wants to merge 2 commits into from

Conversation

EricMarcil
Copy link
Contributor

Added MPX1950 Support Package

@EricMarcil
MPX1950 Support Package
1241d40 
Added MPX1950 Support Package
gavanderhoorn
gavanderhoorn requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review.

I've left a couple of in-line comments/questions.

One additional comment: link_2_l.dae appears to have some issue with normals or other rendering artefacts:

image

motoman_mpx1950_support/config/opw_parameters_mpx1950.yaml Outdated Show resolved Hide resolved
motoman_mpx1950_support/package.xml Outdated Show resolved Hide resolved
@EricMarcil
Correction of MPX1950 model and package description
11457b2 
Flatten surface of link_2_l.dae
Removed erroneous reference to DT and XP models
@EricMarcil
Copy link
Contributor Author

@gavanderhoorn Made the requested changes. Please review.

ted-miller
ted-miller approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Eric's testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn requested changes

@ted-miller ted-miller ted-miller approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricMarcil @gavanderhoorn @ted-miller