Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: added ganty calibration #153

Open
wants to merge 7 commits into
base: melodic-devel
Choose a base branch
from

Conversation

drchrislewis
Copy link
Member

new calibration type to calibrate a robot to the gantry upon which its mounted

@gavanderhoorn
Copy link
Member

I haven't read (all of) the code yet. Could you provide a short description of what this calibrates exactly? Is the visual info used to calibrate precise robot mounting on the gantry, or is it doing something else?

@drchrislewis
Copy link
Member Author

This calibration now works, but I don't feel it is a useful thing to do. I'd hoped it would isolate kinematic alignment errors between the robot and the gantry. It certainly does not to the extent that I'd hoped. In fact I've convinced my self that it only correctly refines 2DOF. When I get time to re-visit this issue, I'll investigate. Is it correct policy to withdraw, or let the wip PR become stale?@gavanderhoorn

@gavanderhoorn
Copy link
Member

I would suggest to close the PR.

It will always be listed in the closed section of the PR listing, and even if you remove the branch from your fork of industrial_calibration, the PR will contain the commits (so you could always recover them if you'd want to later).

@gavanderhoorn
Copy link
Member

I'd hoped it would isolate kinematic alignment errors between the robot and the gantry. It certainly does not to the extent that I'd hoped. In fact I've convinced my self that it only correctly refines 2DOF.

Seeing as I have similar setups: what would work better in your opinion?

@drchrislewis
Copy link
Member Author

@gavanderhoorn We experienced significant improvement in calibration by first following the suggested Fanuc re-mastering before doing wrist/eye-hand calibration. Now the YAK/kinfu output using forward kinematics results in mostly smooth surfaces. Some error may be attributed to intrinsic calibration of the depth sensor. A single image of a flat plane has some visible curl. I'll leave this open until we do an intrinsic calibration and depth calibration on our sensor.

@gavanderhoorn
Copy link
Member

We experienced significant improvement in calibration by first following the suggested Fanuc re-mastering before doing wrist/eye-hand calibration.

hm, ok. So this is with a Fanuc-integrated gantry then?

Would still be nice to have a mfg-agnostic calibration routine/infrastructure for extended kinematic setups. Must be papers about that which could be worth investigating and implementing.

…d it return. Updated to C++14, created launch for astra wrist cal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants