Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing includes #99

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Added missing includes #99

merged 1 commit into from
Jun 1, 2020

Conversation

jontje
Copy link
Contributor

@jontje jontje commented Jun 1, 2020

I have problem to build downstream packages without these includes (when using ROS on Windows).

@jontje jontje requested a review from gavanderhoorn June 1, 2020 08:40
gavanderhoorn
gavanderhoorn approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, do we care about windows 🤷‍♂️ ? ;)

@gavanderhoorn
Copy link
Member

This again shows that we need #92 and #100.

@jontje jontje merged commit 8424448 into ros-industrial:master Jun 1, 2020
@jontje jontje deleted the add_missing_includes branch June 1, 2020 12:39
@jontje
Copy link
Contributor Author

jontje commented Jun 1, 2020

Thanks for the review @gavanderhoorn 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jontje @gavanderhoorn