-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EgmClock message does not represent UNIX time #119
Comments
So just to be clear: this repository is not where ABB maintains its EGM implementation. This is an OSS library which implements an interface to EGM running on an ABB (robot) controller. Issues with EGM itself -- as it seems yours is -- should be either reported to your local ABB branch office (which will then escalate them if/when appropriate) or posted on one of the official ABB fora. From your description, I don't have the impression the issue you are reporting is specific to this library. If you agree, please close the issue. If you post on the RobotStudio forum fi, it would be appreciated if you could post a final comment here with a link to your post there, so we can keep things connected. |
Having written that: I could imagine that RobotStudio uses a non-wallclock internally for the robot controller, and the timestamps you show are relative to when the virtual controller was started. For |
@gavanderhoorn I agree. I thought maybe the documentation needs to be changed. What is the source of information about what |
Perhaps @jontje can clarify where They were added in #32, which copied the files distributed with RobotStudio.
we try not to diverge from upstream here. If the documentation should be updated, it should be done in the upstream files first. Then we can update here. |
@gavanderhoorn what is the upstream? |
The EGM developers @ ABB Robotics. |
@mkatliar: would it be OK to close this issue? Have you reached out to ABB on the RobotStudio fora? We could potentially add a clarifying comment here, but if it's not necessary that would be great. |
Closing. |
@gavanderhoorn the issue is not present on the real robot, so it is probably a RobotStudio bug. I started a discussion on the ABB forum: https://forums.robotstudio.com/discussion/12743 |
This is the response that I got from ABB support:
|
@gavanderhoorn I was also surprised. If it "doesn't do anything with EGM", why does it support EGM commands and even send EGM data. |
Perhaps a lost in translation? Perhaps "doesn't do anything with EGM" actually means: "RobotStudio does not influence any of the internals of EGM". As I wrote in #119 (comment):
perhaps that's what's meant by "RS doesn't do anything with EGM", as in: RS uses some internal clock, doesn't adjust anything in EGM so EGM just reports whatever clock RS happens to use. But this is all (wild) speculation by me (and I don't work for ABB). |
"EGM is not supported by RS" also sounds interesting. |
Yes, I agree. That's the first time I hear that stated about RS. But then again, I'm just "a user". |
I think there has been some misunderstanding somewhere in the support chain, and that response is very vague. When you simulate a robot "in" RobotStudio, is is technically a background process that emulates RobotWare. And it is the RobotWare process that, for example, interpret RAPID code and manages EGM clients and communication. But this is not something users generally don't know about, so it is reasonable to send bug reports etc. via the RobotStudio channels. So the question should have been passed along (by the support people) to the RobotWare R&D, and not RobotStudio R&D. |
yeah, that's in summary what I was trying to say in #119 (comment). @mkatliar: you could perhaps rephrase your question to ABB support and see whether it ends up at the right people? |
@gavanderhoorn I will. |
@gavanderhoorn this is what I got from ABB support:
|
Seems to confirm what I suspected in #119 (comment). thanks for reporting back. Was this in a thread on the RobotStudio forum, or a private email? |
It was in a private email. |
They agreed though that this is not consistent with the documentation:
|
Was there any indication the documentation / comments will be updated? |
No |
The issue seems to be fixed in RobotStudio 21.2.9526.0 -- the timestamps look like UNIX time now. |
Nice, so even if they stated this wouldn't be fixed, it has now been fixed? |
The definition of
EgmClock
in proto/egm.proto isBelow are headers of EGM messages sent from RobotStudio on my system:
The time data
sec: 28397
does not look like "time in seconds and microseconds since 1 Jan 1970".The text was updated successfully, but these errors were encountered: