Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker #4

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Add docker #4

merged 4 commits into from
Mar 12, 2024

Conversation

Yolnan
Copy link
Contributor

@Yolnan Yolnan commented Mar 6, 2024

No description provided.

@Yolnan
Copy link
Contributor Author

Yolnan commented Mar 6, 2024

@marip8 When entering the snp_automate_2022 container, I get notified that "groups: cannot find name for group ID ..." and my username is "I have no name!". I made sure to set the CURRENT_UID environment variable.

Do we want to add a user to the Dockerfile? It currently seems to be root.

@marip8
Copy link
Member

marip8 commented Mar 6, 2024

@marip8 When entering the snp_automate_2022 container, I get notified that "groups: cannot find name for group ID ..." and my username is "I have no name!". I made sure to set the CURRENT_UID environment variable.

Is your machine get your user name from the domain? One of mine does and I get the same error; my other machine is not on a domain and I don't run into this issue. In any case, this issue shouldn't prevent your from running anything

FWIW, mounting the directories below let's the docker image know where your user name and password information can be found

      - /etc/passwd:/etc/passwd:ro
      - /etc/group:/etc/group:ro

.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@Yolnan
Copy link
Contributor Author

Yolnan commented Mar 7, 2024

@marip8 When entering the snp_automate_2022 container, I get notified that "groups: cannot find name for group ID ..." and my username is "I have no name!". I made sure to set the CURRENT_UID environment variable.

Is your machine get your user name from the domain? One of mine does and I get the same error; my other machine is not on a domain and I don't run into this issue. In any case, this issue shouldn't prevent your from running anything

FWIW, mounting the directories below let's the docker image know where your user name and password information can be found

      - /etc/passwd:/etc/passwd:ro
      - /etc/group:/etc/group:ro

I think my laptop is. I did test the container and it seems to work despite the username. I have those directories in the docker compose.yml. Oddly, I think Tyler recommended that I remove them.

@Yolnan Yolnan requested a review from marip8 March 8, 2024 22:56
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/docker-compose.yml Outdated Show resolved Hide resolved
docker/docker-compose.yml Show resolved Hide resolved
docker/docker-compose.yml Outdated Show resolved Hide resolved
@marip8 marip8 merged commit 1d2e175 into ros-industrial-consortium:master Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants