-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mecanum drive #558
Open
bmagyar
wants to merge
21
commits into
ros-controls:noetic-devel
Choose a base branch
from
bmagyar:mecanum_drive
base: noetic-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mecanum drive #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wheel radius can now be retrieved from spheres (as well as cylinders) * the roller's radius is used rather than the wheel's (need an option for this)
…can only take a n X desired speed as it cannot move sideways instantaneously speaking). This second parameter is not used yet.
…eady done for the x direction and the rotation).
…um wheels using realigned rollers.
…which is to be provided is a body velocity, not a space velocity: I need to check whether this is standard or not.
* the odometry pose is expressed in the odom frame (as a ros convention) * the odometry twist is a body twist (as a ros convention) * the input desired twist is also a body twist (as a ros convention)
…delay in the reported velocity).
…t to the center frame in the odometry (FK).
…t to the center frame in the command (IK side).
…as it turned out rather misleading between the different occurences of the odom name (odom used to correspond to a reference frame, a topic and the short name for the odometry class...
Hi! Do you have any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase & quick fixup of #149