Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetic release #234

Closed
bmagyar opened this issue Apr 17, 2016 · 10 comments
Closed

Kinetic release #234

bmagyar opened this issue Apr 17, 2016 · 10 comments

Comments

@bmagyar
Copy link
Member

bmagyar commented Apr 17, 2016

Calling all stations!

I'd like to push this through as fast as it's possible so we are not blocking the release of ors-kinetic-desktop-full (we do through Gazebo).

Are there any PR-s that you'd wish to see merged & volunteer to put effort into it?
I can do the release rain-dance but I need to make sure that we are on the same page.

As there have already been changes in messages on control_msgs I'm going to use kinetic-devel for the new releases.

Please put your (re)marks below: @adolfo-rt @davetcoleman @efernandez @ipa-mdl @paulbovbel @ros-controls/ros_control

@efernandez
Copy link

I can help looking into realtime_tools. There are only two things that need attention there:

  1. One PR (Set up Travis to run tests realtime_tools#8) related with running the tests on Travis, which are currently broken. This should go into kinetic, but we have to fix the PR branch before merging it.
  2. One issue (Lock-free buffer implementation realtime_tools#14) related with the lock-free implementation that currently doesn't support a writeFromRT method. I don't see this in kinetic, as it'd need some development. Apparently, Boost lockfree doesn't support multiple writers, and it's not clear to me that other lock free libraries do.

@bmagyar
Copy link
Member Author

bmagyar commented Apr 18, 2016

👍 @efernandez could you please have a look at the travis stuff for all other ros-controls repos? I'm not very fluent there.

@jacquelinekay
Copy link

How is progress on the Kinetic release?

@bmagyar
Copy link
Member Author

bmagyar commented Apr 22, 2016

Waiting for some API changes on control_toolbox. Once done there, that +
ros_control are ready to roll out.
On 22 Apr 2016 07:17, "Jackie Kay" [email protected] wrote:

How is progress on the Kinetic release?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#234 (comment)

@toliver
Copy link
Contributor

toliver commented May 6, 2016

I would like these 2 PRs to be merged into Kinetic. I'm not sure how far they are to be considered mergeable, but I can definitely work on fixing any issues.

Both of them are focused on allowing to combine several RobotHW into a single one, and therefore allow a single controller to access resources from more than one RobotHW.

@bmagyar
Copy link
Member Author

bmagyar commented May 6, 2016

I have released to Kinetic a few days back.
Merging those 2 PRs have been on the table for a while now... could you please close those 2 PR-s and open a new one against kinetic-devel? I think a single PR containing those 2 commits is ok, easier to discuss.

@bmagyar
Copy link
Member Author

bmagyar commented May 6, 2016

...since the initial kinetic release is done, I'm closing this issue.

@bmagyar bmagyar closed this as completed May 6, 2016
@toliver
Copy link
Contributor

toliver commented May 6, 2016

I will do that.

We are also interested in ros-controls/ros_controllers#185.

It was also left unmerged. Do you think it can make its way into Kinetic?

@bmagyar
Copy link
Member Author

bmagyar commented May 6, 2016

Absolutely. I only need you to implement the changes Adolfo asked for there and help me out by providing as many tests as you can think of ;)
The same rule applies to it though, please close that PR and open a new one after rebasing against kinetic-devel.

@toliver
Copy link
Contributor

toliver commented May 6, 2016

Thanks @bmagyar . I think those changes were already implemented, but we can resume that discussion once we open the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants