-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Improvements and Cleanups #1028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
duringhof,
livanov93,
mcbed,
moriarty and
VX792
February 7, 2024 09:32
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1028 +/- ##
===========================================
+ Coverage 47.71% 71.71% +24.00%
===========================================
Files 41 41
Lines 3871 3628 -243
Branches 1833 1777 -56
===========================================
+ Hits 1847 2602 +755
+ Misses 751 714 -37
+ Partials 1273 312 -961
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Feb 9, 2024
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL/Debian
colcon list
instead of hardcoding it as it is done with the lint jobs.continue-on-error
: The main goal is to detect compilation problems with unsupported C++ features, which are now visible at first glance. Tests remain flaky on theses platforms, which is a different issue.Others
Backport after #1016 and #1017/#1029 and #1030