Second round of dependencies fix (#655) (#656)

* Add missing backward_ros dependency and minor cmake cleanup * Fix unused arg warning (cherry picked from commit d96f662) Co-authored-by: Bence Magyar <[email protected]>
ros-controls · Jun 12, 2023 · 8bfee4b · 8bfee4b
1 parent d62d7fa
commit 8bfee4b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/steering_controllers_library/CMakeLists.txt b/steering_controllers_library/CMakeLists.txt
@@ -55,7 +55,6 @@ target_compile_definitions(steering_controllers_library PRIVATE "STEERING_CONTRO
 if(BUILD_TESTING)
   find_package(ament_cmake_gmock REQUIRED)
   find_package(controller_manager REQUIRED)
-  find_package(hardware_interface REQUIRED)
   find_package(ros2_control_test_assets REQUIRED)
 
   add_rostest_with_parameters_gmock(

diff --git a/steering_controllers_library/package.xml b/steering_controllers_library/package.xml
@@ -18,6 +18,7 @@
 
   <build_depend>generate_parameter_library</build_depend>
 
+  <depend>backward_ros</depend>
   <depend>control_msgs</depend>
   <depend>controller_interface</depend>
   <depend>geometry_msgs</depend>
@@ -36,7 +37,6 @@
 
   <test_depend>ament_cmake_gmock</test_depend>
   <test_depend>controller_manager</test_depend>
-  <test_depend>hardware_interface</test_depend>
   <test_depend>ros2_control_test_assets</test_depend>
 
   <export>

diff --git a/steering_controllers_library/test/test_steering_controllers_library.hpp b/steering_controllers_library/test/test_steering_controllers_library.hpp
@@ -138,7 +138,7 @@ class TestableSteeringControllersLibrary
     return controller_interface::CallbackReturn::SUCCESS;
   }
 
-  bool update_odometry(const rclcpp::Duration & period) { return true; }
+  bool update_odometry(const rclcpp::Duration & /*period*/) { return true; }
 
 private:
   rclcpp::WaitSet ref_subscriber_wait_set_;