-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example 13] Multi-robot system with lifecycle management #417
[Example 13] Multi-robot system with lifecycle management #417
Conversation
825aeec
to
2cf711c
Compare
@Mergifyio backport iron humble |
✅ Backports have been created
|
c2a4a77
to
cbc3fbc
Compare
4ad9687
to
77783f2
Compare
77783f2
to
79f8249
Compare
This pull request is in conflict. Could you fix it @christophfroehlich? |
1 similar comment
This pull request is in conflict. Could you fix it @christophfroehlich? |
Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]>
Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]>
example_13/bringup/config/three_robots_position_command_publishers.yaml
Outdated
Show resolved
Hide resolved
example_13/bringup/config/three_robots_position_command_publishers.yaml
Outdated
Show resolved
Hide resolved
example_13/bringup/config/three_robots_position_command_publishers.yaml
Outdated
Show resolved
Hide resolved
@christophfroehlich minor things but overall I could reproduce things properly (with the above suggested changes) |
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add description for r3bot Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Remove camera links etc * Initial commit for example_13 from old PRs Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Change MD to rst syntax * Update test node syntax * Fix test nodes launch file * Enhance docs * Fix wrench config * Use global joint_state_broadcaster * Add tests * FIx links to files * Add some text * Fix dependencies * Add example13 to workflows+packages * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <[email protected]> * Update example_13/doc/userdoc.rst Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix rst syntax * Use new ros2controlcli verb * Add initial version for launch_test * Add a more complete test * Fix whitespaces * Fix decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix more decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> --------- Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit d6e730f)
* Add description for r3bot Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Remove camera links etc * Initial commit for example_13 from old PRs Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Change MD to rst syntax * Update test node syntax * Fix test nodes launch file * Enhance docs * Fix wrench config * Use global joint_state_broadcaster * Add tests * FIx links to files * Add some text * Fix dependencies * Add example13 to workflows+packages * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <[email protected]> * Update example_13/doc/userdoc.rst Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix rst syntax * Use new ros2controlcli verb * Add initial version for launch_test * Add a more complete test * Fix whitespaces * Fix decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix more decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> --------- Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit d6e730f)
* Add description for r3bot Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Remove camera links etc * Initial commit for example_13 from old PRs Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Change MD to rst syntax * Update test node syntax * Fix test nodes launch file * Enhance docs * Fix wrench config * Use global joint_state_broadcaster * Add tests * FIx links to files * Add some text * Fix dependencies * Add example13 to workflows+packages * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <[email protected]> * Update example_13/doc/userdoc.rst Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix rst syntax * Use new ros2controlcli verb * Add initial version for launch_test * Add a more complete test * Fix whitespaces * Fix decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix more decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> --------- Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit d6e730f) Co-authored-by: Christoph Fröhlich <[email protected]>
* Add description for r3bot Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Remove camera links etc * Initial commit for example_13 from old PRs Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> * Change MD to rst syntax * Update test node syntax * Fix test nodes launch file * Enhance docs * Fix wrench config * Use global joint_state_broadcaster * Add tests * FIx links to files * Add some text * Fix dependencies * Add example13 to workflows+packages * Apply suggestions from code review Co-authored-by: Sai Kishor Kothakota <[email protected]> * Update example_13/doc/userdoc.rst Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix rst syntax * Use new ros2controlcli verb * Add initial version for launch_test * Add a more complete test * Fix whitespaces * Fix decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> * Fix more decimal numbers Co-authored-by: Sai Kishor Kothakota <[email protected]> --------- Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit d6e730f) Co-authored-by: Christoph Fröhlich <[email protected]>
…en they are previously available (#1331) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states
…en they are previously available (#1331) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3)
…en they are previously available (#1331) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3)
…en they are previously available (#1331) (#1339) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3) Co-authored-by: Sai Kishor Kothakota <[email protected]>
…en they are previously available (#1331) (#1340) * Add test to reproduce the behaviour of ros-controls/ros2_control_demos#417 (comment) * Add fix to solve the issue of the publishing non-existing joint_states (cherry picked from commit 87f21b3) Co-authored-by: Sai Kishor Kothakota <[email protected]>
This is a rewrite of #187 including StoglRobotics-forks#7.
Open questions for me:
The problems discussed in the latter PR are summarized in Ressource manager hangs up on lifecycle changes ros2_control#1103. I'd say we can add this example even if the problem is not fixed yet.It uses the rrbot URDF from example_4 and example_5. Should I generate new ones inside example 15? Currently, there is also the FTS broadcaster etc in Rviz, but maybe this wouldn't be necessary and we could just use the same Rrbot instead.-> we decided in the WG meeting to reuse descriptions for the multi-robot examples./joint_states
topic and it seemed to work (better than now, without the necessity of reloading the JSB). The only difference is that with the global one, all joints are within one message. Why would someone need this for multiple robots?