Sleep accurate duration on ros2_control_node #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
destogl
approved these changes
Jan 21, 2021
Co-authored-by: Denis Štogl <[email protected]>
bmagyar
requested changes
Jan 21, 2021
bmagyar
approved these changes
Jan 25, 2021
mahaarbo
pushed a commit
to mahaarbo/ros2_control
that referenced
this pull request
Feb 4, 2021
* measure duration Signed-off-by: Yutaka Kondo <[email protected]> * fix lint Signed-off-by: Yutaka Kondo <[email protected]> * Apply suggestions from code review Co-authored-by: Denis Štogl <[email protected]> * check sleep time is > 0 Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Denis Štogl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current main loop of the
ros2_control_nodedoesn't cycle under correctupdate_ratebecause it ignores the computation time ofread,update, andwritemethods.This PR fixed the problem.
I know we won't need this PR if #260 would be solved but I need it now.