Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gmock CMP0115 (backport #1830) #1849

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fix gmock CMP0115 (backport #1830) #1849

merged 1 commit into from
Nov 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Fixes

--- stderr: controller_manager                                           
CMake Warning (dev) at /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:50 (add_executable):
  Policy CMP0115 is not set: Source file extensions must be explicit.  Run
  "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  File:

    /workspaces/ros2_rolling_ws/src/ros2_control/controller_manager/test/test_hardware_spawner.cpp
Call Stack (most recent call first):
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:37 (_ament_add_gmock_executable)
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock.cmake:65 (ament_add_gmock_executable)
  CMakeLists.txt:197 (ament_add_gmock)
This warning is for project developers.  Use -Wno-dev to suppress it.

This is an automatic backport of pull request #1830 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Nov 4, 2024

This comment was marked as outdated.

@christophfroehlich christophfroehlich marked this pull request as draft November 4, 2024 19:22
@christophfroehlich
Copy link
Contributor

needs #1828 first

This comment was marked as outdated.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.93%. Comparing base (a76101d) to head (f7304f3).
Report is 1 commits behind head on iron.

Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1849      +/-   ##
==========================================
- Coverage   62.96%   62.93%   -0.03%     
==========================================
  Files         113      113              
  Lines       13254    13254              
  Branches     8968     8965       -3     
==========================================
- Hits         8345     8342       -3     
  Misses        898      898              
- Partials     4011     4014       +3     
Flag Coverage Δ
unittests 62.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@bmagyar bmagyar merged commit e58c6c6 into iron Nov 10, 2024
9 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1830 branch November 10, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants