-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spawner] Accept parsing multiple --param-file
arguments to spawner
#1805
base: master
Are you sure you want to change the base?
[Spawner] Accept parsing multiple --param-file
arguments to spawner
#1805
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 88.01% 87.91% -0.10%
==========================================
Files 121 121
Lines 12403 12492 +89
Branches 1108 1124 +16
==========================================
+ Hits 10916 10982 +66
- Misses 1083 1103 +20
- Partials 404 407 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
--param-file
arguments to spawner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a good idea, and implementation LGTM.
Please update the doc section and release notes.
@christophfroehlich Done |
Co-authored-by: Christoph Fröhlich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx :)
This pull request is in conflict. Could you fix it @saikishor? |
This pull request is in conflict. Could you fix it @saikishor? |
When we use multiple controlers to activate or deactivate, it is quite cumbersome to accept only one
--param-file
arg as it is not very scalable. For this reason, now the spawner can accept multiple --param-file args and set the respective param_file to those corresponding controllers.Along with the above mentioned change, now the controllers can accept multiple param-file args as well, and this is very helpful to be able to override parameters between parameter files as how it is done with the standard ROS 2 nodes