Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spawner] Accept parsing multiple --param-file arguments to spawner #1805

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

When we use multiple controlers to activate or deactivate, it is quite cumbersome to accept only one --param-file arg as it is not very scalable. For this reason, now the spawner can accept multiple --param-file args and set the respective param_file to those corresponding controllers.

Along with the above mentioned change, now the controllers can accept multiple param-file args as well, and this is very helpful to be able to override parameters between parameter files as how it is done with the standard ROS 2 nodes

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 74.63768% with 35 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (d714e8b) to head (c0762a4).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...troller_manager/controller_manager/launch_utils.py 0.00% 19 Missing ⚠️
.../controller_manager/controller_manager_services.py 80.00% 5 Missing and 5 partials ⚠️
controller_manager/controller_manager/spawner.py 57.14% 1 Missing and 2 partials ⚠️
controller_manager/src/controller_manager.cpp 70.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   88.01%   87.91%   -0.10%     
==========================================
  Files         121      121              
  Lines       12403    12492      +89     
  Branches     1108     1124      +16     
==========================================
+ Hits        10916    10982      +66     
- Misses       1083     1103      +20     
- Partials      404      407       +3     
Flag Coverage Δ
unittests 87.91% <74.63%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/controller_manager/__init__.py 100.00% <ø> (ø)
controller_manager/test/test_spawner_unspawner.cpp 99.36% <100.00%> (+0.11%) ⬆️
controller_manager/controller_manager/spawner.py 72.22% <57.14%> (+0.44%) ⬆️
controller_manager/src/controller_manager.cpp 78.26% <70.00%> (-0.07%) ⬇️
.../controller_manager/controller_manager_services.py 79.08% <80.00%> (-0.77%) ⬇️
...troller_manager/controller_manager/launch_utils.py 0.00% <0.00%> (ø)

@saikishor saikishor changed the title [Spawner] Accept multiple parsing multiple --param-file arguments [Spawner] Accept parsing multiple --param-file arguments to spawner Oct 19, 2024
@saikishor saikishor changed the title [Spawner] Accept parsing multiple --param-file arguments to spawner [Spawner] Accept parsing multiple --param-file arguments to spawner Oct 19, 2024
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a good idea, and implementation LGTM.

Please update the doc section and release notes.

@saikishor
Copy link
Member Author

Seems to be a good idea, and implementation LGTM.

Please update the doc section and release notes.

@christophfroehlich Done

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx :)

Copy link
Contributor

mergify bot commented Oct 30, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Nov 4, 2024
@saikishor saikishor added the backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. label Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

This pull request is in conflict. Could you fix it @saikishor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants