-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple chainable controller activation bug (backport #1401) #1412
Conversation
(cherry picked from commit 1cc73c2) # Conflicts: # controller_manager/src/controller_manager.cpp # controller_manager/test/test_controller_manager_srvs.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe, the following should fix here as well
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## iron #1412 +/- ##
=======================================
Coverage 75.51% 75.52%
=======================================
Files 42 42
Lines 3366 3371 +5
Branches 1939 1943 +4
=======================================
+ Hits 2542 2546 +4
- Misses 440 441 +1
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automatic backport of pull request #1401 done by Mergify.
Cherry-pick of 1cc73c2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com