Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] matrix stragy: set fail-fast false #1397

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

christophfroehlich
Copy link
Contributor

setting

  fail-fast: false

for matrix strategy. otherwise the main or test build will be cancelled if the other one fails.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (786d5b5) 47.49% compared to head (4f50453) 75.88%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1397       +/-   ##
===========================================
+ Coverage   47.49%   75.88%   +28.38%     
===========================================
  Files          41       41               
  Lines        3556     3359      -197     
  Branches     1938     1935        -3     
===========================================
+ Hits         1689     2549      +860     
+ Misses        459      419       -40     
+ Partials     1408      391     -1017     
Flag Coverage Δ
unittests 75.88% <20.00%> (+28.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 69.43% <20.00%> (+30.66%) ⬆️

... and 31 files with indirect coverage changes

@bmagyar bmagyar merged commit ac76ec9 into ros-controls:master Feb 15, 2024
17 checks passed
@christophfroehlich christophfroehlich deleted the ci_failfast branch March 23, 2024 15:46
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Nov 8, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 8, 2024
(cherry picked from commit ac76ec9)
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
(cherry picked from commit ac76ec9)
bmagyar pushed a commit that referenced this pull request Nov 8, 2024
bmagyar pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants