-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the controller sorting with an approach similar to directed acyclic graphs #1384
Change the controller sorting with an approach similar to directed acyclic graphs #1384
Conversation
…on the command interfaces
… the controller exposing reference interface
… (reconfigure and unloading the controller)
…roller added as predecessor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
===========================================
+ Coverage 0 47.22% +47.22%
===========================================
Files 0 41 +41
Lines 0 3526 +3526
Branches 0 1926 +1926
===========================================
+ Hits 0 1665 +1665
- Misses 0 465 +465
- Partials 0 1396 +1396
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The idea is to change the algorithm of the controller sorting with an approach similar to the Directed Acyclic Graphs (DAGs).
The old test cases work directly with this approach. So, only the main algorithm behind it has changed
Fixes: #1396
Needed for: #1021 and https://github.com/orgs/ros-controls/projects/6/views/9?sliceBy%5Bvalue%5D=Jazzy&pane=issue&itemId=46799899