Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller interfaces remapping proposal #61

Merged

Conversation

saikishor
Copy link
Member

This PR aims to propose the controller interfaces remapping to ease the controller design and to allow integration with custom interfaces

@saikishor saikishor marked this pull request as draft July 22, 2024 09:22
@saikishor saikishor marked this pull request as ready for review July 22, 2024 09:22
@saikishor saikishor marked this pull request as draft July 22, 2024 09:27
@saikishor saikishor marked this pull request as ready for review July 22, 2024 09:27
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal looks fine for me, I also think this could be valuable.
I just don't know yet how much complexity this will add to the CM.

@saikishor
Copy link
Member Author

The proposal looks fine for me, I also think this could be valuable. I just don't know yet how much complexity this will add to the CM.

@christophfroehlich Thanks for reviewing it. As far as I check in the CM, it is not that complex, look at the initial implementation here: saikishor/ros2_control#5

@bmagyar bmagyar merged commit 098248c into ros-controls:master Oct 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants