-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to industrial_ci #20
Conversation
realtime_tools is ready for lunar :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, only small changes needed
.travis.yml
Outdated
@@ -1,47 +1,30 @@ | |||
# Travis Continuous Integration Configuration File For ROS Control Projects | |||
# Author: Dave Coleman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you are switching to industrial_ci, you can remove me as author
.travis.yml
Outdated
sudo: required | ||
dist: trusty | ||
language: generic | ||
|
||
notifications: | ||
email: | ||
recipients: | ||
- [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove me here too, please
.travis.yml
Outdated
matrix: | ||
- ROS_DISTRO=kinetic ROS_REPO=ros | ||
- ROS_DISTRO=kinetic ROS_REPO=ros-shadow-fixed | ||
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed UPSTREAM_WORKSPACE=debian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not add non-shadow-fixed for lunar also?
@davetcoleman: I have removed you from the notifcations. |
Great, thank you! |
.travis.yml
Outdated
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed | ||
matrix: | ||
allow_failures: | ||
- env: ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to allow failures? I think it's better not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just copied from the other repo, I will adjust it.
.travis.yml
Outdated
matrix: | ||
- ROS_DISTRO=kinetic ROS_REPO=ros | ||
- ROS_DISTRO=kinetic ROS_REPO=ros-shadow-fixed | ||
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add regular repo for Lunar?
I have updated the config, please squash-merge. |
The raised points have been addressed
This adds support for lunar
supersedes #8