Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to industrial_ci #20

Merged
merged 3 commits into from
Oct 30, 2017
Merged

switch to industrial_ci #20

merged 3 commits into from
Oct 30, 2017

Conversation

mathias-luedtke
Copy link
Contributor

@mathias-luedtke mathias-luedtke commented Mar 18, 2017

This adds support for lunar
supersedes #8

@mathias-luedtke
Copy link
Contributor Author

mathias-luedtke commented Mar 18, 2017

I will squash it later (or you could squash-merge).
Downstream tests will be run as soon as ros-industrial/industrial_ci#137 was merged.

realtime_tools is ready for lunar :D

Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, only small changes needed

.travis.yml Outdated
@@ -1,47 +1,30 @@
# Travis Continuous Integration Configuration File For ROS Control Projects
# Author: Dave Coleman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you are switching to industrial_ci, you can remove me as author

.travis.yml Outdated
sudo: required
dist: trusty
language: generic

notifications:
email:
recipients:
- [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove me here too, please

.travis.yml Outdated
matrix:
- ROS_DISTRO=kinetic ROS_REPO=ros
- ROS_DISTRO=kinetic ROS_REPO=ros-shadow-fixed
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed UPSTREAM_WORKSPACE=debian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not add non-shadow-fixed for lunar also?

@mathias-luedtke
Copy link
Contributor Author

@davetcoleman: I have removed you from the notifcations.
@bmagyar: I have added the same notifications as for ros-controls/ros_control.

@bmagyar
Copy link
Member

bmagyar commented Oct 29, 2017

Great, thank you!

.travis.yml Outdated
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed
matrix:
allow_failures:
- env: ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to allow failures? I think it's better not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just copied from the other repo, I will adjust it.

.travis.yml Outdated
matrix:
- ROS_DISTRO=kinetic ROS_REPO=ros
- ROS_DISTRO=kinetic ROS_REPO=ros-shadow-fixed
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add regular repo for Lunar?

@mathias-luedtke
Copy link
Contributor Author

I have updated the config, please squash-merge.

@bmagyar bmagyar dismissed davetcoleman’s stale review October 30, 2017 09:54

The raised points have been addressed

@bmagyar bmagyar merged commit ca9c5e9 into ros-controls:kinetic-devel Oct 30, 2017
@bmagyar bmagyar mentioned this pull request Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants