Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper method to lock the pages of memory in the RAM #175

Merged

Conversation

saikishor
Copy link
Member

No description provided.

src/thread_priority.cpp Outdated Show resolved Hide resolved
src/thread_priority.cpp Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 75.36%. Comparing base (144b12c) to head (9f5af0f).

Files with missing lines Patch % Lines
src/thread_priority.cpp 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   81.32%   75.36%   -5.97%     
==========================================
  Files           8        8              
  Lines         316      341      +25     
  Branches       54       62       +8     
==========================================
  Hits          257      257              
- Misses         25       50      +25     
  Partials       34       34              
Flag Coverage Δ
unittests 75.36% <0.00%> (-5.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/thread_priority.cpp 11.42% <0.00%> (-28.58%) ⬇️

@saikishor
Copy link
Member Author

I'm also thinking if it makes sense to continue to thread_priority.hpp or something like realtime_helpers.hpp as it now contains the part of memory locking etc and in the future may be more. So, the header would have a meaningful name. We can add a backward compatibility with deprecation note, if we are interested to do this

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I like the proposal regarding renaming this, but maybe this should be a separate PR? This way we can backport this without breaking the API.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debian an RHEL are happy now, so am I

@christophfroehlich christophfroehlich merged commit f0cede3 into ros-controls:master Oct 30, 2024
27 checks passed
@saikishor saikishor deleted the add/lock_memory/function branch October 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants