-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AsyncFunctionHandler] Add exception handling #172
Merged
bmagyar
merged 6 commits into
ros-controls:master
from
saikishor:async_handler/handle/exceptions
Oct 28, 2024
Merged
[AsyncFunctionHandler] Add exception handling #172
bmagyar
merged 6 commits into
ros-controls:master
from
saikishor:async_handler/handle/exceptions
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
moriarty,
olivier-stasse and
VanshGehlot
September 13, 2024 12:59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 80.39% 81.26% +0.87%
==========================================
Files 8 8
Lines 306 315 +9
Branches 53 54 +1
==========================================
+ Hits 246 256 +10
Misses 25 25
+ Partials 35 34 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
force-pushed
the
async_handler/handle/exceptions
branch
from
September 13, 2024 16:51
0793ba8
to
060e907
Compare
destogl
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and clean.
bmagyar
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the async function handler doesn't work well when the exceptions are then in the callback and this might be an issue that we might face in the short term.
This PR addresses this issue by handling the exceptions and throw in the thread that calls
trigger_async_callback
, so that the main thread is aware of the exception and handle it properly