-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add jazzy 🚀 #165
[CI] Add jazzy 🚀 #165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 7 7
Lines 237 237
Branches 40 40
=======================================
Hits 181 181
Misses 26 26
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good to me :)
@saikishor I haven't questioned this, just added jazzy. But you are right, it works without specifying a repos file. And because all of them are empty, there was no difference between binary and semi-binary. So I deleted also the semi-binary workflow file. Edit: nope, only ICI works without the repos file. I have to change the other imported workflows from ros2_control_ci to work without a given repos file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me. Thanks for the changes :)
Jobs for jazzy-main are failing, but jazzy-testing works fine already.