Simplify access for robot description from CM by overriding RM #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
force-pushed
the
fix_api
branch
from
75171aa
to
f758cfc
Compare
christophfroehlich
force-pushed
the
fix_api
branch
from
d07249b
to
2153cd5
Compare
saikishor
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
@christophfroehlich LGTM thank you so much for taking time and propagating this change here as well. This would be very helpful to have it merged for the comparability CI.
Great job 👏🏽👏🏽
ahcorde
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to adjust compatibility with cleanup done in ros-controls/ros2_control#1354.
This is a rewrite of ros-controls/gz_ros2_control#265 adapted for gazebo_ros2_control. I tested it successfully with the demos .
gazebo_ros2_control won't be released for rolling distro on noble, but this PR repairs the compatibility for the ros2_control rolling version on humble/iron.