Improvement on the integral contribution implementation #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integral of the error is computed in a class member, and the integral contribution is computed as of it, instead of doing all together. Now, setting the integral gain to zero dynamically cancel the integral contribution.
Additional update:
Function
getCurrentPIDErrors(...)
now returns the integral of the position error, and not the contribution. Because of this, also the tests were modified. TestsintegrationWindupZeroGainTest
(actually, this one makes no sense now, since the error is directly given instead of obtaining by diving the term by the gain) andintegrationWindupTest
check the windup constraint on the computed command.I don't know how this affects the dependant packages, but I believe the change is worthy.
Resolve #32.