Added feedback

Signed-off-by: ahcorde <[email protected]>
ros-controls · Jul 1, 2020 · 68a81d3 · 68a81d3
1 parent d7dc461
commit 68a81d3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/include/control_toolbox/pid_ros.hpp b/include/control_toolbox/pid_ros.hpp
@@ -55,7 +55,7 @@ class PidROS
 {
 public:
   /*!
-   * \brief Destructor of PidROS class.
+   * \brief Constructor of PidROS class.
    *
    * The node is passed to this class to handler the ROS parameters, this class allows
    * to add a prefix to the pid parameters
@@ -88,11 +88,6 @@ class PidROS
     initialize(topic_prefix);
   }
 
-  /*!
-   * \brief Destructor of PidROS class.
-   */
-  ~PidROS() = default;
-
   /*!
    * \brief Initialize the PID controller and set the paramaters
    * \param p The proportional gain.

diff --git a/src/pid_ros.cpp b/src/pid_ros.cpp
@@ -78,6 +78,7 @@ PidROS::getBooleanParam(const std::string & param_name, bool & value)
   }
 }
 
+// TODO(anyone): to-be-removed once this functionality becomes supported by the param API directly
 bool
 PidROS::getDoubleParam(const std::string & param_name, double & value)
 {
-Original file line number
+Diff line change
@@ Expand Up @@
       }
     }
+    // TODO(anyone): to-be-removed once this functionality becomes supported by the param API directly
     bool
     PidROS::getDoubleParam(const std::string & param_name, double & value)
     {
@@ Expand Down @@