Resolve package paths and repos

[fmauch]

As raised earlier (e.g. here there currently are problems with getting the correct subdir for individual packages.

Now, without having looked at the code too deeply, I think that the following should work:

• Take the URL from the rosdistro's distribution.yaml
• append archive/release/melodic/<pkg_name>/<version>.tar.gz
• Set the directory to the first (and only) subdirectory inside the extracted archive

The names don't seem to be consistent, as for example, for ros_control_boilerplate it is ros_control-release-release-melodic-combined_robot_hw while for moveit_ros_benchmarks it is moveit-release-release-melodic-moveit_ros_benchmarks-1.0.5-1.

I just wanted to raise this issue here to start discussing it.

[fmauch]

If we swap this if/else

and use this URL directly to generate the versioned URL instead of extracting the target first, this should be working. What do you think @bionade24?

[bionade24]

If we swap this if/else
You mean the if/elif, don't you?
and use this URL directly to generate the versioned URL instead of extracting the target first, this should be working. What do you think @bionade24?
I'm can't follow your idea. Why should be the 1st folder in the tarball be correct?
What has the release tarball URL generation to do with the tarball itself?
A bit of (at least pseudo) code would probably make your idea more clear. Thx for spending your time on this project.

[fmauch]

Aye, I think I can make a q&d proof of concept PR later this weekend.

…

On July 31, 2020 5:22:56 PM GMT+02:00, Oskar Roesler ***@***.***> wrote: > If we swap [this if/else](https://github.com/bionade24/ros-aur-helpers/blob/master/aurci/general.py#L35) You mean the if/elif, don't you? > and use this URL directly to generate the versioned URL instead of extracting the `target` first, this should be working. What do you think @bionade24? I'm can't follow your idea. Why should be the 1st folder in the tarball be correct? What has the release tarball URL generation to do with the tarball itself? A bit of (at least pseudo) code would probably make your idea more clear. Thx for spending your time on this project. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #1 (comment)