Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add dcm_qa as a submodule and use in travis #110

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

yarikoptic
Copy link
Contributor

would require learning a bit about git modules but IMHO it is the correct way to do it and bind version (commit) of dcm_qa into specific state of dcm2niix. If anything changes within dcm_qa, you would need first o push dcm_qa to github and then commit the change here

@yarikoptic
Copy link
Contributor Author

oh so lovely -- look at the travis output -- looks like legit "failures" to me

@yarikoptic yarikoptic changed the title ENH: add dcm_qa as a submodule ENH: add dcm_qa as a submodule and use in travis Jun 23, 2017
@neurolabusc
Copy link
Collaborator

@ningfei: since @yarikoptic is modifying the files you are creating, perhaps you want to review them and if you are happy you can marge the pull request. In theory it is a nice idea to not only validate that the code compiles, but also validate sensible results.

@ningfei
Copy link
Collaborator

ningfei commented Jun 23, 2017

Looks cool! Just correct the reference json files (duplicated "InstitutionName"). Now the travis output should show "exited with 0".

@ningfei ningfei merged commit 1fabe1d into rordenlab:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants