-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple additional XA30 fields? #606
Comments
Also, I don't know the name of it, but it appears that (0021,105c) may be a useful field where XA30 is including additional imaging options. e.g., for a T1w scan with "water excitation": |
Per https://www.mathworks.com/matlabcentral/mlc-downloads/downloads/submissions/42997/versions/94/previews/dicm_dict.m/index.html?access_key= |
@mharms can I suggest you make suggestions for BIDS fields for these DICOM tags. Am I correct that you are proposing the following translation: |
Yes, that is my proposal, and those names are consistent with their DICOM field names. Thx. |
BTW: By "BIDS field" name, I was assuming that you were just referring to what to name it in the sidecar json of |
@mharms can you test the latest development branch. It should add these to the sidecar. I am late in releasing the Spring 2022 release, so if you can provide a timely review we can generate a new stable version. |
Looks good. One minor suggestion would be to position Edit: Or maybe putting |
Forgot to mention, do you want to do anything such that the CMRR PhysioLogs are no longer converted? |
The stdout during conversion reports messages like the following regarding the PhysioLog files:
But .nii.gz and .json files (and .bval and .bvec, if related to a dMRI scan) are getting created for the PhysioLog dicoms anyway. |
@mharms can you test the current development branch and close this issue if it comprehensively fulfills all your suggestions. The spring 2022 release is overdue (my fault entirely), so I am eager to close all outstanding issues. |
The current dev version is no longer generating any files for "PhysioLog" series from my XA30 test set. It is also no longer generating .bval and .bvec files for the "SBRef" series accompanying a dMRI series, although perhaps that is desirable? (Basically, I got no .bval/.bvec files at all). Also, regarding the stdout reporting for a PhysioLog series:
|
One other minor, unrelated thing I just noticed. Is there a character limit on the
but the resulting json is missing the final 'S':
|
Looks good as regards the bval/bvec generation. However, I'm still seeing truncated |
Sorry, I did not have a concrete example. I created a GE DICOM with very verbose scan options and the latest commit to the development branch should support this. Please validate with your data. The example is from dcm_qa_nih with the scan options changed with dcmodify. |
That indeed grabbed all of the |
* tag 'v1.0.20220720': (65 commits) GE Direct field mapping (TE1/TE2) (rordenlab#617) GE Direct field mapping (TE1/TE2) (rordenlab#617) Issue 618 (rordenlab#618) Update notes Siemens XA30 ASL parameters and ImageTypeText 0021,1175 Reset PET values for classic DICOMs (rordenlab#616) PostLabelDelay for XA30, FrameDuration is only for 4D datasets (rordenlab#616) shims are signed (rordenlab#608) AcquisitionVoxelSize before any interpolation or resampling within reconstruction or image processing Add AcquisitionVoxelSize tag for Siemens ASL (rordenlab#608) Store GE ShimSetting as array (rordenlab#608) GE sequence details (rordenlab#608) Philips slice timing notes Verbose scan options (issue 606) Change scanOptions scan options is long string, fix bvec rejection (rordenlab#606) Ignore non-spatial physio data (rordenlab#606) Flipping Y also flips sign of determinant Better Siemens XA support (rordenlab#606) Report DwellTime for Siemens XA (rordenlab#240) ...
Wondering if there is value in including the following additional 0018 fields that Siemens XA30 appears to now be populating:
The text was updated successfully, but these errors were encountered: