-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON keys with dots (periods) #483
Comments
The other thing I could see is promoting to an object and getting "sWipMemBlock": {"AdFree3": -25, ...} Not sure if that would collapse onto some other notation that produces objects... |
For what is worth, "sWipMemBlock.AdFree4": [-25, 25, 25, 25, -25, -25,...] |
Closing this. The upcoming version will remove the dots. |
The BIDS standard stores values in JSON key-value pairs. Users are allowed to define their own filenames (keys) as long as they are not defined. At the request of the Oxford BASIL team, recent versions of dcm2niix now copy a large number of fields from the Siemens CSA header to the BIDS sidecar. I copied the filenames verbatim. However, it has been brought to my attention that a few of these include a dot in the key name, and that this confounds usage with tools like Matlab and JavaScript (which requires square bracket syntax to handle these). For example:
I would like to suggest that we simply remove the dot from these keys, e.g.
sWipMemBlockAdFree7
. However, I would like to make sure that no one feels strongly about this change.I know that @satra has raised concerns about sanitizing information, and in general I try to avoid changes that might impact other code. @effigies and @mcraig-ibme might have thoughts on this.
The text was updated successfully, but these errors were encountered: