Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the ParallelReductionFactorInPlane no longer extracted for 3D? #314

Closed
pvelasco opened this issue Jul 22, 2019 · 1 comment
Closed

Comments

@pvelasco
Copy link

Hi,
I'm looking at the json files of some anatomical sequences (both T1w and T2w) and I have noticed that the ParallelReductionFactorInPlane is no longer present.

Looking at the history of nii_dicom_batch.cpp, I found that the change was introduced in commit c014f25, but I cannot find any explanation of why 3D sequences no longer report it.

Does anybody remember why?

neurolabusc added a commit that referenced this issue Jul 22, 2019
@neurolabusc
Copy link
Collaborator

Reinstated in latest development commit. I think I removed this simply because I did not think it was required for 3D files and I added ParallelReductionFactor detection for UIH data. This was reported in the dcm_qa_uih submodule. I will update the dcm_qa_uih submodule for the next stable release.

neurolabusc added a commit to neurolabusc/dcm_qa_uih that referenced this issue Aug 1, 2019
yarikoptic added a commit to neurodebian/dcm2niix that referenced this issue May 6, 2020
* tag 'v1.0.20190720':
  Update dcm_qa submodule.
  Handle rare VRs (https://www.aliza-dicom-viewer.com/download/datasets)
  New default merge option "-m o" will merge CTs and segment MRIs (https://discourse.slicer.org/t/odd-dicom-import/7576)
  --progress option (rordenlab#314; rordenlab#312)
  Tune verbosity (rordenlab#312)
  GE Slice Timing From Protocol Data Block (rordenlab#311)
  Desparate guess of GE slice times from ProtocolDataBlock (clone dicm2nii, assumes TA close to TR)
  Support interleaved (rordenlab#309)
  Slice times from ucMode (rordenlab#309)
  GE number of slice discrepancy (rordenlab#306)
  Simplify slice timing code, develop stc validation (https://github.com/neurolabusc/dcm_qa_stc)
  hdr.vox_offset is a float not integer (https://www.nitrc.org/forum/message.php?msg_id=27155)
  BIDS tags for PASL fairest sequent
  Read 0019,1029 (rordenlab#296)
  Generate warning rather than error when palette colors are detected (UNFmontreal/Dcm2Bids#54)
  Update tinydir call (rordenlab#298)
  Bruker 4D datasets: correct slice ordering
  Bruker 4D datasets: Fix parametric maps grouping
  Changes up to divest v0.8.1
  Support isotropic scans for NRRD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants