Update function URLs to fix a number of tests (SRS, ChemSpider) #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #422, #423.
Brief description of the PR:
Two functions broke, probably because their webservice URLs changed. This PR updates these URLs so they work again.
srs_query()
now uses a new URL and returns a list of tibbles instead of a list of data frames. I switched to tibble because the output contains nested data frames as well which print better with tibble.is.inchikey(type = "chemspider")
used a ChemSpider webservice which did not require an API key. It seems this webservice is no longer working. I implemented another ChemSpider API, but the alternative requires an API key. Because of the API key I also recorded all related tests usingvcr
.When I R CMD checked the package I received some notes which were probably related to a new roxygen2 version. To handle these, I 1. tidied
get_cid()
documentation, 2. created separate R scripts to describe eachwebchem
data set, 3. moved part of thewebchem-package.R
script tozzz.R
, 4. Implemented this "_PACKAGE" thing inwebchem-package.R
which seems to guide roxygen2 in creating the documentation page behind?webchem
.I plan to merge this PR first to ensure all checks pass and then rebase other PRs on the new master.
PR task list:
devtools::document()