Feature bcpc extend features #420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 31, 2024 13:10
Added name_fr, name_zh, name_ru as scraped fields from page
…age, so +3 length for fluazinam), and new `bcpc_query` from arguments.
|
Thanks @AlexisBrgn for opening this PR. Some of the webservices changed which broke a few tests we already had. I fixed these, can you please rebase on the current master? After rebase, please also rerun devtools::document(), this will remove man/webchem.Rd. Is this PR still work in progress? |
|
Thanks for the heads up I'll dig into it as soon as I manage to free up some time to contribute.
Yes it is still very rough, the basic features work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Brief description of the PR
Extended features from bcpc.R :
bcpc_querynow returns localesThis PR is unsolicited but it was a shame the exposed functions didn't allow to search in other languages when the info was right there. I don't like refactoring other people's code but the existing codebase would've made extending features a bit messy.
Maybe this is the occasion to address #295? I'm not sure I understand it clearly tho.
PR task list:
devtools::document()