Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing epiSuite data on chemspider #139

Closed
stanstrup opened this issue Nov 24, 2017 · 3 comments
Closed

Handle missing epiSuite data on chemspider #139

stanstrup opened this issue Nov 24, 2017 · 3 comments
Labels
bug Unexpected problem or unintended behavior

Comments

@stanstrup
Copy link
Collaborator

Some CS records are missing epiSuite data.

Example here: https://www.chemspider.com/Chemical-Structure.21106900.html

The parsing for those will fail.

I added a fix to the PR here: #136
I hope that is OK.
@eduardszoecs eduardszoecs mentioned this issue Nov 25, 2017
Closed
@eduardszoecs eduardszoecs added the bug Unexpected problem or unintended behavior label Nov 25, 2017
@eduardszoecs
Copy link
Member

Please use separate PRs per issue. [Will cherry-pick it for now].

eduardszoecs added a commit that referenced this issue Nov 25, 2017
@eduardszoecs
cherry-pick from #136.
601410a 
fixes issue #139
@stanstrup
Copy link
Collaborator Author

Yes sorry about that. I was in a hurry and needed something with all the fixes to finish something.

Thanks for dealing with it this fast.

@eduardszoecs
Copy link
Member

No problem. Note, that I also turned all your issues into tests (ensuring this will newer come up again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eduardszoecs @stanstrup