-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gittargets: data version control for the targets package #486
Comments
Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type |
🚀 Error: Issue template has no 'repourl' 👋 |
Missing values: author1, repourl |
Sorry about that, should be fixed now. |
@ropensci-review-bot check package |
Thanks, about to send the query. |
🚀 Editor check started 👋 |
Checks for gittargets (v0.0.0.9000)git hash: b6eadc4b
Important: All failing checks above must be addressed prior to proceeding Package License: MIT + file LICENSE 1. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The final measure (
1a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 2.
|
name | conclusion | sha | date |
---|---|---|---|
check | success | b6eadc | 2021-11-17 |
cover | success | b6eadc | 2021-11-17 |
lint | success | b6eadc | 2021-11-17 |
pkgdown | success | b6eadc | 2021-11-17 |
3b. goodpractice
results
R CMD check
with rcmdcheck
rcmdcheck found no errors, warnings, or notes
Test coverage with covr
Package coverage: 13.35
The following files are not completely covered by tests:
file | coverage |
---|---|
R/tar_git_checkout.R | 0% |
R/tar_git_init.R | 0% |
R/tar_git_log.R | 0% |
R/tar_git_ok.R | 0% |
R/tar_git_snapshot.R | 0% |
R/tar_git_status_code.R | 0% |
R/tar_git_status_data.R | 0% |
R/tar_git_status_targets.R | 0% |
R/tar_git_status.R | 0% |
R/utils_assert.R | 0% |
R/utils_git.R | 30.77% |
Cyclocomplexity with cyclocomp
No functions have cyclocomplexity >= 15
Static code analyses with lintr
lintr found no issues with this package!
Package Versions
package | version |
---|---|
pkgstats | 0.0.2.72 |
pkgcheck | 0.0.2.107 |
Editor-in-Chief Instructions:
Processing may not proceed until the items marked with ✖️ have been resolved.
|
Yeah, that makes sense. I'll get started on getting this moving. |
Thank you both! Related: I have not been able to correctly set up Git on the Windows GitHub Actions for |
@ropensci-review-bot assign @adamhsparksas editor |
@ropensci-review-bot assign @adamhsparks as editor |
Assigned! @adamhsparks is now the editor |
@ropensci-review-bot check package |
Thanks, about to send the query. |
🚀 Editor check started 👋 |
Checks for gittargets (v0.0.0.9000)git hash: 5c046f1d
Package License: MIT + file LICENSE 1. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The final measure (
1a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 2.
|
name | conclusion | sha | date |
---|---|---|---|
check | success | 5c046f | 2021-11-18 |
cover | success | 5c046f | 2021-11-18 |
cover-ubuntu | success | 5c046f | 2021-11-18 |
lint | success | 5c046f | 2021-11-18 |
pkgdown | success | 5c046f | 2021-11-18 |
3b. goodpractice
results
R CMD check
with rcmdcheck
rcmdcheck found no errors, warnings, or notes
Test coverage with covr
Package coverage: 100
Cyclocomplexity with cyclocomp
No functions have cyclocomplexity >= 15
Static code analyses with lintr
lintr found no issues with this package!
Package Versions
package | version |
---|---|
pkgstats | 0.0.3.51 |
pkgcheck | 0.0.2.130 |
Editor-in-Chief Instructions:
This package is in top shape and may be passed on to a handling editor
Hi @wlandau, sorry for the delays. I'll endeavour to complete my checks today and start looking for reviewers so we can at least have some assigned before Christmas. |
Editor checks:
Editor commentsThanks for this submission, Will. There's a few of us that were excited to see this one submitted for review. Everything looks good from here with my editor checks. I don't have any major suggestions so I'll start looking for reviewers now. |
Thanks, @adamhsparks! I am excited too. |
Logged review for mdneuzerling (hours: 5) |
@ropensci-review-bot submit review time 7 |
Logged review for smwindecker (hours: 7) |
@ropensci-review-bot approve gittargets |
Approved! Thanks @wlandau for submitting and @smwindecker, @mdneuzerling for your reviews! 😁 To-dos:
Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @stefaniebutland in your reply. She will get in touch about timing and can answer any questions. We maintain an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding (with advice on releases, package marketing, GitHub grooming); the guide also feature CRAN gotchas. Please tell us what could be improved. Last but not least, you can volunteer as a reviewer via filling a short form. |
@mdneuzerling, I noted after reading your approval that you still hadn't ticked the "Statement of need" in your checklist. I'm assuming that this has been met since you've approved the package revisions in your most recent post regarding updates to the README. If this is correct, could you please just tic that box to complete the review for us? 🙏 |
@adamhsparks Sorry about that! Done. |
Well done, @wlandau! Thanks for this new package submission to rOpenSci. I'm guessing you know the drill now. If you need assistance with anything, please let me know. |
Amazing! Thanks @adamhsparks for facilitating the process and thanks @smwindecker and @mdneuzerling for the reviews! @adamhsparks, would you be willing to grant me admin permissions at https://github.com/ropensci/gittargets? The rOpenSci transfer process still removes that on my end. |
Ah, sorry I didn't see this:
|
@ropensci-review-bot finalize transfer gittargets |
@ropensci-review-bot finalize transfer |
@ropensci-review-bot finalize transfer of gittargets |
Transfer completed. The |
I still do not have admin permissions. Did I need to add myself to the |
Other than that, I believe all the to-dos are now complete. |
@wlandau I've now added you to that team. You hadn't received any invitation to it beforehands, correct? Thanks for the bug catching. 🙏 |
Thanks, @maelle! I did not receive an invitation before, but I do have admin permissions now. |
Sorry @wlandau, our badge server went to sleep a month ago without anybody realising - I've re-enabled it, so it should update soon. |
Thanks Mark! Looks to be fixed. |
Date accepted: 2022-01-12
Due date for @smwindecker: 2021-12-20Submitting Author Name: Will Landau
Submitting Author Github Handle: @wlandau
Repository: https://github.com/wlandau/gittargets
Version submitted: 0.0.0.9000
Submission type: Standard
Editor: @adamhsparks
Reviewers: @smwindecker, @mdneuzerling
Due date for @mdneuzerling: 2021-12-28
Archive: TBD
Version accepted: TBD
Language: en
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
Version control systems such as Git help researchers track changes and history in data science projects, and the targets package minimizes the computational cost of keeping the latest results reproducible and up to date. The gittargets package combines these two capabilities. The targets data store becomes a version control repository and stays synchronized with the Git repository of the source code. Users can switch commits and branches without invalidating the targets pipeline.
gittargets
is for people who usetargets
for reproducible analysis pipelines and Git for tracking the code files of those pipelines.Packages
gh
,gert
,git2r
, andgit2rdata
all work with Git from R, but in a way that is more general, less opinionated, and lesstargets
-specific thangittargets
.gittargets
establishes a separate repository for thetargets
data that is linked to the project's code repository. This allows the code and data to synchronize without affecting the efficiency or the size of the code repository.N/A
N/A
Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
Do you intend for this package to go on CRAN?
Do you intend for this package to go on Bioconductor?
Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
Code of conduct
The text was updated successfully, but these errors were encountered: