Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Adv variable from update #84

Closed
timtrice opened this issue Jun 24, 2017 · 0 comments
Closed

Remove Adv variable from update #84

timtrice opened this issue Jun 24, 2017 · 0 comments
Labels
Bugs Fix me, I'm broken! DON'T DELAY!!! High Priority NOW NOW NOW

Comments

@timtrice
Copy link
Contributor

Updates do not have advisory numbers. Remove this variable from dataset.
@timtrice timtrice added Bugs Fix me, I'm broken! DON'T DELAY!!! High Priority NOW NOW NOW labels Jun 24, 2017
timtrice added a commit that referenced this issue Jun 24, 2017
@timtrice
Remove Adv from update (#84)
0c8cdb2 
* Remove variable `Adv` from `update`. Updates do not have advisory
numbers

* Updated test dataset.

* All tests and checks pass.
timtrice added a commit that referenced this issue Jun 26, 2017
@timtrice
Modify, clean up return dataframes
2d539ca 
* `Key` variable added to `discus` dataframes. `Key` will be NA for all cyclones >= 2005. Should not be <= 2006. (#80)

* Removed `Adv` variable from `posest` dataframes. Position estimates do not have advisory numbers. (#81)

* Removed `Adv` variable from `update`. Updates do not have advisory numbers. (#84)

* Added variable `Key` to `get_public` dataframes. (#85)

* Added variable `Key` to `get_update` dataframes. (#86)

* Removed non-existent wind radii variables in `get_fstadv`. Hrs 48 and 72 hours only have 34 and 50kt wind fields. Hrs 96 and 120 have none. (#89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bugs Fix me, I'm broken! DON'T DELAY!!! High Priority NOW NOW NOW
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timtrice