Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data for precipitation #56

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

femiguez
Copy link
Contributor

@femiguez femiguez commented Aug 27, 2021

Description

Currently, NASA POWER is not returning precipitation. It is returned as -999.0, which is not captured by the na argument in readr:read_csv. I have expanded the argument to hopefully capture a few more of these.

Related Issue

Example

I just ran the example in ?get_power with this change and it returns 'NA' instead of '-999'

@adamhsparks
Copy link
Member

Hi Fernando,
Earlier in the day before you submitted this, I'd committed this change to the devel branch:
62db544

I suppose your fix is probably the better option though. I'll revert my commit and apply your PR to that branch.

@adamhsparks adamhsparks changed the base branch from main to devel September 1, 2021 11:46
@adamhsparks adamhsparks merged commit 0020c0a into ropensci:devel Sep 1, 2021
@Ebedthan
Copy link

Ebedthan commented Sep 14, 2021

Hi @adamhsparks,
The fixed version is not yet deployed on CRAN, I would not have understood what was going on if have not found this PR.
Please can the fixed version be submitted to CRAN?
And can you please kindly give me some details on why NASA power is not returning precipitation at the time?
Thanks

@adamhsparks
Copy link
Member

The plan is to submit a new version to CRAN with bug fixes and other enhancements as I’ve done in the past. Since this is not a major bug, and is easily fixed by the end user, either replacing the values with a proper NA or installing from GitHub, it’s not a high priority at the moment. I will do that once I’m satisfied that there are no other bugs that need to be fixed and when I have the time to do it.

This is just a client for the POWER API, you need to direct questions about the data themselves to the POWER team, not to me please.

@femiguez
Copy link
Contributor Author

@Ebedthan If you need precipitation you data you can try the chirps package (Adam is one of the developers).

We actually do not use precipitation data from NASA POWER even when it does not return NA (-999). :)

@Ebedthan
Copy link

Ooh thanks so much, @femiguez, I'll try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants