-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data repo #303
Data repo #303
Conversation
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Don't merge yet. I'll be adding some more unit tests |
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Signed-off-by: Thierry Onkelinx <[email protected]>
Hi @ThierryO I have looked through the code and have identified two calls to command-line Thanks |
I'll update the PR when the new functionality becomes available. |
I have added the
I'm currently changing S4 methods to standard R functions and S4 classes to S3 classes. This might take me a couple of weeks. Since that work also affect code in this PR, I let you know when I have completed it. |
I'm curious why you want to switch from S4 to S3. |
The reason I want to switch to S3 is to simplify the design and make future development easier. With this change, most of the R functions are one-liners that only pass data to the C-level of git2r. |
I'm working on a new (and improved) version of this based on the new S3 classes. |
This PR solves #301. It is mainly a port from functions available in our
n2khelper
package. Therefor, thetestthat
framework is used for unit testing.