Fix dbplyr db_supports_table_alias_with_as bug
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeane
changed the title
db_supports_table_alias_with_as bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dbplyr 4.2.0, there is a new method
db_supports_table_alias_with_aswhich will determine ifASis used or not. This usually just works due to inheritance, but with odbc drivers it did not. This is because the connection class that odbc returns with an actual connection (PostgreSQL) is hardcoded in dbplyr, but when we mock the connection when we are playing back, we don't have that information available.Also: Cleaning up some of the linting annotations (mostly just running styler and accepting what it gives me)