Overlap with dblog?

[krlmlr]

URL: https://github.com/r-dbi/dblog

Blog post: https://www.r-dbi.org/blog/dbi-3-2/, section "Logging with the {dblog} package"

My package uses a different approach -- implementing a LoggingDBIDriver object that wraps another arbitrary DBIDriver object. So far it seems to work well.

I wonder if we should replace logging with custom callbacks that your package could register? That would expand dblog into a generic hooking mechanism. Or perhaps implement helpers that make it easier to wrap DBI backends?

[pachadotdev]

Dear Kirill Thanks for your interest in dittodb. I tend to support the idea of wrapping DBI backends, but I am biased because I had too many problems with SQL Server lately. Jonathan probably has a better idea. Best,

…

On Thu, Aug 27, 2020, 6:14 AM Kirill Müller ***@***.***> wrote: URL: https://github.com/r-dbi/dblog Blog post: https://www.r-dbi.org/blog/dbi-3-2/, section "Logging with the {dblog} package" My package uses a different approach -- implementing a LoggingDBIDriver object that wraps another arbitrary DBIDriver object. So far it seems to work well. I wonder if we should replace logging with custom callbacks that your package could register? That would expand dblog into a generic hooking mechanism. Or perhaps implement helpers that make it easier to wrap DBI backends? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#131>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACM7UOLATKVZLKU2LG2DQR3SCYWWVANCNFSM4QM2BC6A> .

[jonkeane]

Hello!

I will admit I did not know that {dblog} existed when I started work on {dittodb}, but it looks like a really neat package. The idea of callbacks sounds like a good one for {dittodb} capturing queries and results, and one that would probably be more stable in the long run.

I'm happy to help out in the effort to add that functionality and think that callback functionality would be something that would be useful even beyond {dittodb}. Do you plan on extending {dblog} to do that? Or Start a new package just for the callback wrapper/registration? (or I guess in principle it could be included in {DBI} itself?) Any way you approach it, I would be happy to help out with development/testing/etc.!