Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed download of earlier release ensembl genomes #61

Merged
merged 6 commits into from
Oct 26, 2020
Merged

Fixed download of earlier release ensembl genomes #61

merged 6 commits into from
Oct 26, 2020

Conversation

Roleren
Copy link
Contributor

@Roleren Roleren commented Oct 25, 2020

No description provided.

@Roleren Roleren mentioned this pull request Oct 25, 2020
Closed
@Roleren
Copy link
Contributor Author

Roleren commented Oct 26, 2020

Ok, good to go.

Now protein, DNA fasta and DNA gtf all can access ensembl releases correctly down to 46

HajkD
HajkD reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@HajkD HajkD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Håkon,

Thank you so much for this fantastic work!

This looks already very good!

I was wondering whether it would be possible to remove the .gitignore and biomartr.Rproj files?

Also did you intend to have the files 4e804be#diff-37a250f18367de0bfad6a62d1185f5cefe40b040d87a931ff91e7dd8e31b1095, 4e804be#diff-bb1fc76f2b917b76d717878d885089f85425717f3ffcb1342ef9c2dda26c6263, 4e804be#diff-bb1fc76f2b917b76d717878d885089f85425717f3ffcb1342ef9c2dda26c6263, 4e804be#diff-e58c80fb18d02cb222525db2270dd7e31cc04fbccd200eb223a7f7b2facb27b5, and 4e804be#diff-229c833c7c0b3966466ee67fb9fa4f235f3028473f9449c1da79dced1f0f91b4 within the package? Maybe we should remove them?

After addressing these small things, I am happy to merge!

Very well done!

Many thanks,
Hajk

@Roleren
Copy link
Contributor Author

Roleren commented Oct 26, 2020 •
edited
Loading

Yes, that was not intentional, looks like the tests create a subfolder. I removed .gitignore and .rproj too.

@HajkD
Copy link
Member

HajkD commented Oct 26, 2020

Absolutely brilliant! Looks perfect now!

@HajkD HajkD merged commit 49861a6 into ropensci:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HajkD HajkD HajkD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roleren @HajkD