file missing in cras_write

R/cras_write.R

@@ -4,7 +4,7 @@
 #' (from \code{template_create}) to a raw string following the CRediT authors
 #' statement format of "author1: contributions author2: contributions ..."
 #' @param cras_table A data.frame created using \code{create_template()}
-#' @param file The text file to be created. If NULL (default), the statement is
+#' @param file The text file to be created. If not provided (default), the statement is
 #' returned as a string instead of written to a file.
 #' @param drop_authors If TRUE (default) the authors without contributions are
 #' removed from the statement. If FALSE, they are kept without contributions
@@ -38,7 +38,7 @@
 
 
 cras_write <- function(cras_table,
-                       file = NULL,
+                       file,
                        drop_authors = TRUE,
                        overwrite = FALSE,
                        markdown = TRUE,
@@ -75,7 +75,7 @@ cras_write <- function(cras_table,
 
   cras <- gsub(" $", "", cras)
 
-  if(is.null(file)){
+  if(missing(file)){
     return(cras)
   }
 

tests/testthat/test-cras_write.R

@@ -32,8 +32,8 @@ test_that("authors are not dropped when drop_authors is false", {
   expect_gt(grep("HIJ", cras_write(cras_table, drop_authors = FALSE)), 0)
 })
 
-test_that("cras_write returns vector when file is null",{
-  expect_equal(cras_write(cras_table, file = NULL, quiet = TRUE,), cras_md)
+test_that("cras_write returns vector when file is missing",{
+  expect_equal(cras_write(cras_table, quiet = TRUE,), cras_md)
 })
 
 test_that("do not overwrite the file", {