Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation in summary tables #28

Closed
maelle opened this issue Sep 3, 2021 · 7 comments
Closed

Add documentation in summary tables #28

maelle opened this issue Sep 3, 2021 · 7 comments
Labels
documentation Improvements or additions to documentation

Comments

@maelle
Copy link
Contributor

maelle commented Sep 3, 2021

Maybe a link to docs somewhere?

Or something on hover, but I'd assume it needs more checks of accessibility for screenreader users.

@mpadge
Copy link
Member

mpadge commented Sep 3, 2021

Image from @maelle to contextualise this:

image (1)

The "measure" column needs explaining and interpreting

@mpadge
Copy link
Member

mpadge commented Oct 8, 2021

The solution which will be committed presently comes from this gist - much simpler and more flexible than tippy.

@mpadge mpadge closed this as completed in fa2f1d8 Oct 8, 2021
@mpadge
Copy link
Member

mpadge commented Oct 8, 2021

@maelle That was fun! Thanks - check it out yourself!

Screenshot from 2021-10-08 11-55-42

Note for posterity in this issue: This ability relies on an internal tooltip_dictionary() function to match variable names to text entries for tooltips. This has to be manually curated whenever the stats section of the report is modified. Currently will only deposit tooltips for variables included in the dictionary, while ignoring all others.

@maelle
Copy link
Contributor Author

maelle commented Oct 8, 2021

Awesome! Do we have an idea of how usable it is with a screen reader?

@mpadge
Copy link
Member

mpadge commented Oct 8, 2021

Re-opening as ping to check that - I'll post a link here for you when that's done

@mpadge mpadge reopened this Oct 8, 2021
@maelle
Copy link
Contributor Author

maelle commented Oct 18, 2021

Some notes

@mpadge
Copy link
Member

mpadge commented Oct 18, 2021

Oh yeah, that's right, GitHub disables all HTML in issues. A note will have to be added

@mpadge mpadge added the documentation Improvements or additions to documentation label Nov 18, 2021
@mpadge mpadge closed this as completed in acd14a6 Mar 21, 2022
mpadge added a commit that referenced this issue Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants