Skip to content
This repository has been archived by the owner on Nov 10, 2024. It is now read-only.

Remove home argument from get_timeline #550

Closed
hadley opened this issue Apr 1, 2021 · 2 comments · Fixed by #553
Closed

Remove home argument from get_timeline #550

hadley opened this issue Apr 1, 2021 · 2 comments · Fixed by #553

Comments

@hadley
Copy link
Collaborator

hadley commented Apr 1, 2021

Since according to https://developer.twitter.com/en/docs/twitter-api/v1/tweets/timelines/api-reference/get-statuses-home_timeline, you can only get the home timeline for the authenticated user (i.e. get_my_timeline())

@llrs
Copy link
Collaborator

llrs commented Apr 1, 2021

The home argument changes the endpoint it is called:
api <- if (home) "/1.1/statuses/home_timeline" else "/1.1/statuses/user_timeline"
Perhaps it signals that it should be organized differently to better mimic Twitter API?

@hadley
Copy link
Collaborator Author

hadley commented Apr 1, 2021

I think home makes sense in get_timeline_user() since get_timeline() and get_my_timeline() share a lot of code, so I'll deprecate it get_timeline() but otherwise leave it alone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants